// Top matches · 5 engineers

100% MATCH
895 MERGED PRSCODE PROTECTIVENESS AND OPENNESS TO REFACTORING

WHY THEM  Writes about code protectiveness and openness to refactoring in their own reviews.

“The goal here is to react to both `isPageFocused` and `hasNew` so making it an effect is the easiest way to do that. We might want to refactor polling more generally and move some of this state around but I'm hesitant to do this now.”
Go deeper
Edaly Ahmed
@tomorro · Paris, France
36% MATCH
944 MERGED PRS

WHY THEM  Has reviewed this kind of change before.

“the name here is confusing. I saw that you define a new type here `apps/dove/modules/ordering/components/order-payments/order-payments.tsx` but it's confusing as it's not really an order. I think that would be clearer if order-payments component have a maxAmount props and internally calculate the remaining to pay wdyt ?”
Go deeper
Linus Torvalds
Linux Foundation · Portland, OR
2% MATCH
72 MERGED PRS

WHY THEM  Has reviewed this kind of change before.

“Ok, I think I made a mistake in making the LFO be -1 .. 1 - most LFO users really seem to want a 0 .. 1 range instead. The -1 .. 1 range seemed to make some conceptual sense for a sinewave LFO, but I already made the sawtooth range be 0 .. 1, and having different ranges for different LFO's was clearly already ugly, and looking at users like this the ugliness is just even more obvious now. My bad. I think I will fix this, but please just re-submit with a sign-off, and I'll deal with the range issue separately.”
Go deeper

People also asked