WHY THEM  Writes about curious skeptic who prefers self documenting code in their own reviews.

“Feedback from an external perspective: there is a lot of methods here I think we can factorize a bit with filters maybe ideas: - have an array instead of two arguments for the roles - filter arg with the role? - filter arg with the status - filter arg to exclude tomorro exclusion - etc...”

WHY THEM  Writes about communication style and tone in their own reviews.

“i mean the async gap — i don't think react has any way to tie setStates after await back to the cause. asynccontext will solve this but it isn't there yet”

WHY THEM  Writes about developer communication style in their own reviews.

“when onCompleted or onFailed fires, phase stays 'monitoring' so this effect keeps re-running and the callbacks fire multiple times — you need to transition phase to 'completed' or 'failed' here to stop it”

WHY THEM  Writes about communication style in their own reviews.

“We could add an event `connect_error` From Cursor: > The token is read from localStorage at socket creation time. If the token is expired or missing, the server-side gateway will likely reject the handshake. Socket.io's default behavior on connect_error is to keep retrying with exponential backoff — but it will keep using the same stale token, so it'll retry forever and never succeed. In the current hook, this means: isConnected stays false status stays 'loading' The user sees an infinite loading state with no feedback”

WHY THEM  Writes about simon rabourg communication style in their own reviews.

“This one could be updated and improved, but it implies a structure change on the backend and I'm not as confident to deliver it now. I propose to merge it like this and arrange this beginning of next week. ”

WHY THEM  Has reviewed this kind of change before.

“We should do this for our other BLE callback things too, like BLEObject::writeCompleted, and get rid of the stupid need to pre-declare those things as member functions.”