@Matthieu-gotomorro
Matthieu Alcaro
- Merged PRs
- 946
- Reviews
- 888
- Repos
- 8
- Followers
- 0
- Merged
- 95%
tomorro/aura#407Ok with that @7mioda ?APR 2026tomorro/ai-api#486Do not look at that file, this part of the code is removed in the next PRAPR 2026tomorro/aura#392We could add an event `connect_error` From Cursor: > The token is read from localStorage at socket creation time. If the token is expired or missing, the server-side gateway will lAPR 2026tomorro/aura#392Lof of things done here, could we split that into separate methods and call them ? Just for clarity of codeAPR 2026tomorro/aura#392This is never used no?APR 2026tomorro/aura#385Just not sure of the wording `.contract.ts` (not defined like that in the codebase at the moment) But can be discussed or updated laterAPR 2026tomorro/aura#385Why protected ?APR 2026tomorro/aura#385Is it intentional to catch and silently fail ?APR 2026tomorro/aura#385Would it be better in a transaction ? Is it a problem if the first succeed and the 2nd fails ?APR 2026tomorro/aura#385As I understand, this is used to make it smoother in the end UI. This is a presentation concern and not really related to the service. In my opinion it should be coded in the frontAPR 2026tomorro/aura#385Just for cleaner file, move that down under imports sectionAPR 2026tomorro/aura#385I'm not sure to understand thatAPR 2026tomorro/aura#385I feel like this is a huge method violating Single Responsibility Principle. Could we improve that?APR 2026tomorro/aura#385Is it really useful to redefine an inner function instead of directly calling `this.gateway.emitSourcing`APR 2026tomorro/aura#385French labels here is it desired behavior ? Are they translated ?APR 2026tomorro/aura#380I'll check that but i think it's a wanted behaviorAPR 2026tomorro/aura#379Fixed in next PRAPR 2026tomorro/aura#376Same as earlier, i don't really like the fact that you mutate the object but doesn't save it in the same method. What do you think @7mioda ?APR 2026tomorro/aura#376if `mode = both` you'll have duplicates on: - `Lecture du contrat` - `Lecture et compréhension du contrat`APR 2026tomorro/aura#376`playbook-reading` => Lecture et compréhension du `playbook` instead of `contrat` no?APR 2026